feat: fetching of a secured Algolia key [BB-8083][BACKPORT] #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x29a
changed the title
This was referenced Nov 19, 2023
Agrendalath
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
👍
- I tested this: compared the diff to the original PR; it's not a clean backport, but looks good
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #1.
I tested the original version with Nutmeg, and it doesn't work well. There were random re-renders on opening the profile dropdown and other issues, like requests to non-existent endpoints. That's why the target branch,
opencraft-release/nutmeg.2, is based on openedx@04c0ea3, which was added 11 April 2022, because3.42.5version ofedx-enterprisewas released 7 April 2022. It's worth to mention that Palm version of this MFE runs much smoother than this one.Testing steps
Testing steps are very similar to those for #1, just replace
palmwithnutmegwhenever it occurs and use0x29a/bb8083/per-user-algolia-key-nutmeginstead of0x29a/bb8083/per-user-algolia-keybranches.Also keep in mind these pitfalls:
make dev.up.large-and-slow, you'll have to runmake dev.up.redis.CONTENT_PRODUCT_SOURCE_ALLOW_LISTinenterprise_catalog/apps/catalog/constants.py. You can skip this and othersource-related steps.enterprise-catalogmay fail due to anensurepipissue. In this case, editDockerfileto installpython3-venv(there ispython3.8-venv, but it doesn't work for some reason).enterprise-catalogmay be crashing during provisioning. If you experience this, add the following change todocker-compose.yml:services: mysql: image: mysql:5.7 + command: ["mysqld", "--character-set-server=utf8mb3", "--collation-server=utf8mb3_general_ci"] container_name: enterprise.catalog.mysql environment: MYSQL_ROOT_PASSWORD: "" MYSQL_ALLOW_EMPTY_PASSWORD: "yes" MYSQL_DATABASE: "enterprise_catalog"